Skip to content

Add --host (-h) command line option for the Server address. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

YaacovHazan
Copy link
Collaborator

@YaacovHazan YaacovHazan commented Jun 14, 2023

Fixes #87

This new option is the same as the old --server, and we keep the old only for backwards compatibility.

This commit introduced a breaking changes, as the -h option was used as the short option for --help

This new option is the same as the old --server, and we keep
the old only for backwards compatibility.

This commit introduced a breaking changes, as the -h option was
used as the short option for --help
@YaacovHazan YaacovHazan requested a review from yossigo June 14, 2023 19:02
@codecov-commenter
Copy link

Codecov Report

Merging #224 (f96cde6) into master (5c8be9c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f96cde6 differs from pull request most recent head b302d76. Consider uploading reports for the commit b302d76 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   56.87%   56.90%   +0.03%     
==========================================
  Files          21       21              
  Lines        4283     4284       +1     
==========================================
+ Hits         2436     2438       +2     
+ Misses       1847     1846       -1     
Impacted Files Coverage Δ
memtier_benchmark.cpp 52.81% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use -h --hostname instead (or in addition) to -s to match redis-cli, redis-benchmark...
3 participants